[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230108221734.GA345366-robh@kernel.org>
Date: Sun, 8 Jan 2023 16:17:34 -0600
From: Rob Herring <robh@...nel.org>
To: Rafał Miłecki <zajec5@...il.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
NXP Linux Team <linux-imx@....com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Michael Walle <michael@...le.cc>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
u-boot@...ts.denx.de,
Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH 1/3] dt-bindings: nvmem: u-boot,env: add MAC's
#nvmem-cell-cells
On Thu, Jan 05, 2023 at 06:10:36PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@...ecki.pl>
>
> U-Boot's "ethaddr" environment variable is very often used to store
> *base* MAC address. It's used as a base for calculating addresses for
> multiple interfaces. It's done by adding proper values. Actual offsets
> are picked by manufacturers and vary across devices.
>
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>
> ---
> Documentation/devicetree/bindings/nvmem/u-boot,env.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> index cbc5c69fd405..1c139bd689ea 100644
> --- a/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/u-boot,env.yaml
> @@ -50,7 +50,11 @@ properties:
>
> ethaddr:
> type: object
> - description: Ethernet interface's MAC address
> + description:
> + Ethernet interfaces base MAC address. The first argument is an offset.
The 2nd sentence belongs in the '#nvmem-cell-cells' description.
> + properties:
> + "#nvmem-cell-cells":
> + const: 1
>
> additionalProperties: false
>
> @@ -72,6 +76,7 @@ examples:
> reg = <0x40000 0x10000>;
>
> mac: ethaddr {
> + #nvmem-cell-cells = <1>;
> };
> };
> };
> --
> 2.34.1
>
>
Powered by blists - more mailing lists