linux-kernel - Re: [PATCH v8 04/16] x86/virt/tdx: Add skeleton to initialize TDX on demand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <145def74bc800a625d51f528c20c1be4da8c9e27.camel@intel.com>
Date:   Sun, 8 Jan 2023 22:26:29 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Luck, Tony" <tony.luck@...el.com>,
        "bagasdotme@...il.com" <bagasdotme@...il.com>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "Shahar, Sagi" <sagis@...gle.com>,
        "imammedo@...hat.com" <imammedo@...hat.com>,
        "Gao, Chao" <chao.gao@...el.com>,
        "Brown, Len" <len.brown@...el.com>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "Huang, Ying" <ying.huang@...el.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>
Subject: Re: [PATCH v8 04/16] x86/virt/tdx: Add skeleton to initialize TDX on
 demand

On Fri, 2023-01-06 at 09:14 -0800, Dave Hansen wrote:
> On 12/8/22 22:52, Kai Huang wrote:
> > 
> > The TDX module will be initialized in multi-steps defined by the TDX
> > module and most of those steps involve a specific SEAMCALL:
> > 
> >  1) Get the TDX module information and TDX-capable memory regions
> >     (TDH.SYS.INFO).
> >  2) Build the list of TDX-usable memory regions.
> >  3) Construct a list of "TD Memory Regions" (TDMRs) to cover all
> >     TDX-usable memory regions.
> >  4) Pick up one TDX private KeyID as the global KeyID.
> >  5) Configure the TDMRs and the global KeyID to the TDX module
> >     (TDH.SYS.CONFIG).
> >  6) Configure the global KeyID on all packages (TDH.SYS.KEY.CONFIG).
> >  7) Initialize all TDMRs (TDH.SYS.TDMR.INIT).
> 
> I don't think you really need this *AND* the "TODO" comments in
> init_tdx_module().  Just say:
> 
> 	Add a placeholder tdx_enable() to initialize the TDX module on
> 	demand.  The TODO list will be pared down as functionality is
> 	added.

Yes agreed.  Will do.  Thanks.