[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y7xXWrR3jD3cUxWv@duo.ucw.cz>
Date: Mon, 9 Jan 2023 19:05:14 +0100
From: Pavel Machek <pavel@....cz>
To: Ian Pilcher <arequipeno@...il.com>
Cc: lee@...nel.org, linux-leds@...r.kernel.org,
linux-kernel@...r.kernel.org, kabel@...nel.org
Subject: Re: [PATCH v13 1/2] docs: Add block device (blkdev) LED trigger
documentation
Hi!
This is the crazy interface I'm complaining about:
> * /sys/class/leds/<led>/link_dev_by_path
> * /sys/class/leds/<led>/unlink_dev_by_path
> * /sys/class/leds/<led>/unlink_dev_by_name
> * /sys/class/leds/<led>/linked_devices
Echoing filenames into files (with symlink resolution) is quite
strange, is it? As is having two different unlink interfaces.
I believe we do have other places handling similar N:M configuration
problems, so this should be similar to some of them.
Obvious improvement would be having only "link_dev_by_name" and
"unlink_dev_by_name", but then, unlink should really be rm.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)
Powered by blists - more mailing lists