linux-kernel - Re: [PATCH] mm: Fix two spelling mistakes in highmem.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 09 Jan 2023 19:09:46 +0100
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Ira Weiny <ira.weiny@...el.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Alexander Potapenko <glider@...gle.com>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Tony Luck <tony.luck@...el.com>, linux-kernel@...r.kernel.org,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>, linux-mm@...ck.org
Subject: Re: [PATCH] mm: Fix two spelling mistakes in highmem.h

On giovedì 5 gennaio 2023 18:02:30 CET Ira Weiny wrote:
> On Thu, Jan 05, 2023 at 01:13:05PM +0100, Fabio M. De Francesco wrote:
> > Substitute two occurrences of "higmem" with "highmem" in highmem.h.
> 
> The change looks fine but for Andrew's benefit I believe this patch is based
> on the other one you submitted to fix kmap_local_folio()?[1]  Is that
> correct?

Yes, it is. 
I had completely forgotten that previous patch.
Thanks for noticing it and for providing its link to Andrew.

Fabio

> 
> [1]
> https://lore.kernel.org/all/20230105120424.30055-1-fmdefrancesco@gmail.com/
> 
> With that note:
> 
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
> 
> > Suggested-by: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> > ---
> > 
> >  include/linux/highmem.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> > index 7b0085a61e67..ae1670ccdf45 100644
> > --- a/include/linux/highmem.h
> > +++ b/include/linux/highmem.h
> > @@ -86,7 +86,7 @@ static inline void kmap_flush_unused(void);
> > 
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> > 
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> > 
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effect 
of
> > 
> > @@ -119,7 +119,7 @@ static inline void *kmap_local_page(struct page 
*page);
> > 
> >   * virtual address of the direct mapping. Only real highmem pages are
> >   * temporarily mapped.
> >   *
> > 
> > - * While it is significantly faster than kmap() for the higmem case it
> > + * While it is significantly faster than kmap() for the highmem case it
> > 
> >   * comes with restrictions about the pointer validity.
> >   *
> >   * On HIGHMEM enabled systems mapping a highmem page has the side effect 
of
> > 
> > --
> > 2.39.0