lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20230109183026.157393-1-sj@kernel.org>
Date:   Mon,  9 Jan 2023 18:30:26 +0000
From:   SeongJae Park <sj@...nel.org>
To:     yang.yang29@....com.cn
Cc:     sj@...nel.org, akpm@...ux-foundation.org, damon@...ts.linux.dev,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        xu.panda@....com.cn
Subject: Re: [PATCH linux-next] mm/damon/sysfs-schemes: use strscpy() to instead of strncpy()

Hello Xu,


Thank you for this patch.

On Mon, 9 Jan 2023 19:46:55 +0800 (CST) <yang.yang29@....com.cn> wrote:

> From: Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>

Reviewed-by: SeongJae Park <sj@...nel.org>

Thanks,
SJ

> ---
>  mm/damon/sysfs-schemes.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c
> index f0dabe3e2dc0..86edca66aab1 100644
> --- a/mm/damon/sysfs-schemes.c
> +++ b/mm/damon/sysfs-schemes.c
> @@ -353,8 +353,7 @@ static ssize_t memcg_path_store(struct kobject *kobj,
>  	if (!path)
>  		return -ENOMEM;
> 
> -	strncpy(path, buf, count);
> -	path[count] = '\0';
> +	strscpy(path, buf, count + 1);
>  	filter->memcg_path = path;
>  	return count;
>  }
> -- 
> 2.15.2

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ