linux-kernel - Re: [PATCH v5 0/3] Reliability improvements for Microchip MPF FPGA manager

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7uwfCPAl15Db8G6@yilunxu-OptiPlex-7050>
Date:   Mon, 9 Jan 2023 14:13:16 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     Ivan Bornyakov <i.bornyakov@...rotek.ru>
Cc:     linux-fpga@...r.kernel.org,
        Conor Dooley <conor.dooley@...rochip.com>,
        Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Tom Rix <trix@...hat.com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-kernel@...r.kernel.org, system@...rotek.ru
Subject: Re: [PATCH v5 0/3] Reliability improvements for Microchip MPF FPGA
 manager

On 2023-01-09 at 08:47:42 +0300, Ivan Bornyakov wrote:
> On Fri, Dec 30, 2022 at 12:29:19PM +0300, Ivan Bornyakov wrote:
> > A couple of reliability improvements for Microchip Polarfire FPGA
> > manager:
> >  * move SPI I/O buffers out of stack
> >  * rewrite status polling routine in a time measurable way
> > 
> > Also improve mpf_ops_write() code readability by separating single data
> > frame writing routine.
> > 
> > ChangeLog:
> >   v1:
> > [https://lore.kernel.org/linux-fpga/20221223123854.8023-1-i.bornyakov@metrotek.ru/]
> >   v2:
> >     * split into 3 distinct patches
> > [https://lore.kernel.org/linux-fpga/20221226142326.8111-1-i.bornyakov@metrotek.ru/]
> >   v3:
> >     * fix polling stop condition in mpf_poll_status() as Ilpo suggested.
> > [https://lore.kernel.org/linux-fpga/20221227100450.2257-1-i.bornyakov@metrotek.ru/]
> >   v4:
> >     * more verbose comment for mpf_poll_status()
> > [https://lore.kernel.org/linux-fpga/20221229104604.2496-1-i.bornyakov@metrotek.ru/]
> >   v5:
> >     * revord "fpga: microchip-spi: move SPI I/O buffers out of stack"
> >       commit message "Use allocated buffers" -> "Use cacheline aligned
> >       buffers"
> >     * drop __aligned(ARCH_KMALLOC_MINALIGN) attribute of struct mpf_priv
> >       member "rx". tx and rx are used synchronously by dma, they could
> >       share a cacheline.
> > 
> > Ivan Bornyakov (3):
> >   fpga: microchip-spi: move SPI I/O buffers out of stack
> >   fpga: microchip-spi: rewrite status polling in a time measurable way
> >   fpga: microchip-spi: separate data frame write routine
> > 
> >  drivers/fpga/microchip-spi.c | 145 +++++++++++++++++++----------------
> >  1 file changed, 79 insertions(+), 66 deletions(-)
> > 
> > -- 
> > 2.38.2
> > 
> 
> Friendly ping.
> 

Patch #1 is good to me now. And applied this series to for-next

Thanks,
Yilun