linux-kernel - Re: [PATCH 3/7] nvmet: introduce bdev_zone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b6d70ab-c04a-2411-7f7c-37bbcb50608a@nvidia.com>
Date:   Mon, 9 Jan 2023 07:42:53 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Pankaj Raghav <p.raghav@...sung.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "kernel@...kajraghav.com" <kernel@...kajraghav.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "hare@...e.de" <hare@...e.de>,
        "bvanassche@....org" <bvanassche@....org>,
        "snitzer@...nel.org" <snitzer@...nel.org>,
        "dm-devel@...hat.com" <dm-devel@...hat.com>,
        "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>,
        "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "hch@....de" <hch@....de>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "gost.dev@...sung.com" <gost.dev@...sung.com>
Subject: Re: [PATCH 3/7] nvmet: introduce bdev_zone_no helper

On 1/6/23 00:33, Pankaj Raghav wrote:
> A generic bdev_zone_no() helper is added to calculate zone number for a
> given sector in a block device. This helper internally uses disk_zone_no()
> to find the zone number.
> 
> Use the helper bdev_zone_no() to calculate nr of zones. This let's us
> make modifications to the math if needed in one place.
> 
> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>

with Bart's comments fixed...

looks good....

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck