linux-kernel - [Regression] Bug 216903 - HiRes Scroll for Performance Mouse MX broken in 6.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b74f4337-2e52-fe01-666c-d08335e9f4f4@leemhuis.info>
Date:   Mon, 9 Jan 2023 10:14:37 +0100
From:   "Linux kernel regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Filipe Laíns <lains@...eup.net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Bastien Nocera <hadess@...ess.net>
Cc:     Jiri Kosina <jikos@...nel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, berilko@...il.com,
        Stefan Brüns <stefan.bruens@...h-aachen.de>,
        "regressions@...ts.linux.dev" <regressions@...ts.linux.dev>
Subject: [Regression] Bug 216903 - HiRes Scroll for Performance Mouse MX broken in 6.1

Hi, this is your Linux kernel regression tracker.

I noticed a regression report in bugzilla.kernel.org. As many (most?)
kernel developer don't keep an eye on it, I decided to forward it by
mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216903 :

>  berilko@...il.com 2023-01-08 19:14:21 UTC
> 
> Since 6.1 Kernel driver for hid-logitech-hidpp no more detect Performance MX as FastScroll
> 
> Self-made patch is:
> --- archlinux-linux/drivers/hid/hid-logitech-hidpp.c	2023-01-09 00:41:25.310773805 +0700
> +++ archlinux-linux/drivers/hid/hid-logitech-hidpp.c	2023-01-09 01:09:10.844967608 +0700
> @@ -3479,7 +3479,7 @@
>  						  HIDPP_GET_REGISTER,
>  						  HIDPP_ENABLE_FAST_SCROLL,
>  						  NULL, 0, &response);
> -		if (!ret) {
> +		if (!ret || /* Patch for Performance MX */ hidpp->hid_dev->product == 0x101a) {
>  			hidpp->capabilities |= HIDPP_CAPABILITY_HIDPP10_FAST_SCROLL;
>  			hid_dbg(hidpp->hid_dev, "Detected HID++ 1.0 fast scroll\n");
>  		}
> 
> [reply] [−] Comment 1 Stefan Brüns 2023-01-08 23:39:50 UTC
> 
> Unfortunately, the hires auto detection is broken for HID++1.0 devices.
> 
> https://elixir.bootlin.com/linux/latest/source/drivers/hid/hid-logitech-hidpp.c#L3477
> 
> ```
> 		ret = hidpp_send_rap_command_sync(hidpp,
> 						  REPORT_ID_HIDPP_SHORT,
> 						  HIDPP_GET_REGISTER,
> 						  HIDPP_ENABLE_FAST_SCROLL,
> 						  NULL, 0, &response);
> ```
> 
> This command tries to read from register 0x40, while the FAST_SCROLL feature is BIT(6) (0x40) in register 0x01.
> 
> For my M705, enabling and disabling of FAST_SCROLL is possible (writing 0x42/0x02 to register 0x1), and the current setting can be read back.
> 
> I don't think auto-detection is possible for HID++1.0 devices.
> 

See the ticket for more details.

BTW, let me use this mail to also add the report to the list of tracked
regressions to ensure it's doesn't fall through the cracks:

#regzbot introduced: v6.0..v6.1
https://bugzilla.kernel.org/show_bug.cgi?id=216903
#regzbot title: hid: HiRes Scroll for Performance Mouse MX broken
#regzbot ignore-activity

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.