linux-kernel - Re: [PATCH 2/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: add input-enable and bias-bus-hold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08fae328-2343-6b59-237b-95fea0f3ddcc@linaro.org>
Date:   Mon, 9 Jan 2023 10:19:03 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Shawn Guo <shawn.guo@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Richard Acayan <mailingradian@...il.com>,
        Vinod Koul <vkoul@...nel.org>,
        krishna Lanka <quic_vamslank@...cinc.com>,
        Iskren Chernev <me@...ren.info>,
        Martin Botka <martin.botka@...ainline.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/9] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: add
 input-enable and bias-bus-hold

On 08/01/2023 21:08, Rob Herring wrote:
> On Fri, Dec 30, 2022 at 02:56:38PM +0100, Krzysztof Kozlowski wrote:
>> Allow bias-bus-hold and input-enable properties (already used in
>> SC8280XP LPASS LPI nodes):
>>
>>   sa8540p-ride.dtb: pinctrl@...0000: tx-swr-default-state: 'oneOf' conditional failed, one must be fixed:
>>     'pins' is a required property
>>     'function' is a required property
>>     'clk-pins', 'data-pins' do not match any of the regexes: 'pinctrl-[0-9]+'
>>     'bias-bus-hold' does not match any of the regexes: 'pinctrl-[0-9]+'
>>     'gpio2' does not match '^gpio([0-1]|1[0-8])$'
> 
> Wrong warning?

No, it is still correct, just one warning for two issues:
1. patch 1 for wrong GPIO
2. patch 2 for bias-bus-hold

I can drop last line here (gpio2 does not match).

Best regards,
Krzysztof