linux-kernel - Re: [PATCH v2 2/5] arm64: dts: fsl-imx8qm-device.dtsi: add io-channel-cells to adc nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 09:23:15 +0000
From:   Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:     "shawnguo@...nel.org" <shawnguo@...nel.org>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        "linux-imx@....com" <linux-imx@....com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "peng.fan@....com" <peng.fan@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Frank.Li@....com" <Frank.Li@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "festevam@...il.com" <festevam@...il.com>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
Subject: Re: [PATCH v2 2/5] arm64: dts: fsl-imx8qm-device.dtsi: add
 io-channel-cells to adc nodes

On Mon, 2023-01-09 at 16:19 +0800, Shawn Guo wrote:
> On Mon, Jan 02, 2023 at 06:10:19PM +0100, Marcel Ziswiler wrote:
> > From: Max Krummenacher <max.krummenacher@...adex.com>
> > 
> > This commit adds io-channel-cells property to the ADC nodes. This
> > property is required in order for an IIO consumer driver to work.
> > Especially required for Apalis iMX8 QM, as the touchscreen driver
> > uses ADC channels with the ADC driver based on IIO framework.
> > 
> > Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> > Signed-off-by: Max Krummenacher <max.krummenacher@...adex.com>
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>
> 
> fsl-imx8qm-device.dtsi in subject?

(;-p).

Let me fix this in a v3. Thanks!

> Shawn

Cheers

Marcel

> > ---
> > 
> > (no changes since v1)
> > 
> >  arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-
> > dma.dtsi
> > index a943a1e2797f..6e5ef8b69bf8 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
> > @@ -270,6 +270,7 @@ i2c3: i2c@...30000 {
> >  
> >         adc0: adc@...80000 {
> >                 compatible = "nxp,imx8qxp-adc";
> > +               #io-channel-cells = <1>;
> >                 reg = <0x5a880000 0x10000>;
> >                 interrupts = <GIC_SPI 240 IRQ_TYPE_LEVEL_HIGH>;
> >                 interrupt-parent = <&gic>;
> > @@ -284,6 +285,7 @@ adc0: adc@...80000 {
> >  
> >         adc1: adc@...90000 {
> >                 compatible = "nxp,imx8qxp-adc";
> > +               #io-channel-cells = <1>;
> >                 reg = <0x5a890000 0x10000>;
> >                 interrupts = <GIC_SPI 241 IRQ_TYPE_LEVEL_HIGH>;
> >                 interrupt-parent = <&gic>;
> > -- 
> > 2.35.1