linux-kernel - Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0df69da-e881-46aa-da51-eb3b610dee57@linaro.org>
Date:   Mon, 9 Jan 2023 09:48:51 +0000
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Rafał Miłecki <rafal@...ecki.pl>
Cc:     INAGAKI Hiroshi <musashino.open@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] nvmem: u-boot-env: align endianness of crc32 values

Hi Rafal,

On 06/01/2023 19:15, Rafał Miłecki wrote:
> Hi Srinivas,
> 
> On 2022-11-11 18:41, Srinivas Kandagatla wrote:
>> On 12/10/2022 16:51, INAGAKI Hiroshi wrote:
>>> This patch fixes crc32 error on Big-Endianness system by conversion of
>>> calculated crc32 value.
>>>
>>> Little-Endianness system:
>>>
>>>    obtained crc32: Little
>>> calculated crc32: Little
>>>
>>> Big-Endianness system:
>>>
>>>    obtained crc32: Little
>>> calculated crc32: Big
>>>
>>> log (APRESIA ApresiaLightGS120GT-SS, RTL8382M, Big-Endianness):
>>>
>>> [    8.570000] u_boot_env 
>>> 18001200.spi:flash@0:partitions:partition@...00: Invalid calculated 
>>> CRC32: 0x88cd6f09 (expected: 0x096fcd88)
>>> [    8.580000] u_boot_env: probe of 
>>> 18001200.spi:flash@0:partitions:partition@...00 failed with error -22
>>>
>>> Fixes: f955dc1445069 ("nvmem: add driver handling U-Boot environment 
>>> variables")
>>>
>>> Signed-off-by: INAGAKI Hiroshi <musashino.open@...il.com>
>>> ---
>>
>> Applied thanks,
> 
> has this patch been lost somewhere in the process?
> 
> I'm quite sure I saw it in linux-next.git and probably in nvmem.git. Now
> it seems to be gone.
Yes, I had to revert this one as next reported sparse warnings [1] with 
this patch which were not addressed.




--srini

[1] https://lore.kernel.org/linux-mm/202212040713.rVney9e8-lkp@intel.com/T/