linux-kernel - Re: [PATCH] x86/retbleed: add "stuff" mode admin documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7vsQz8qompLCk3h@gmail.com>
Date:   Mon, 9 Jan 2023 11:28:19 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH] x86/retbleed: add "stuff" mode admin documentation


* Randy Dunlap <rdunlap@...radead.org> wrote:

> Add admin documentation for "retbleed=stuff", based on commit
> description and source code.
> 
> Fixes: d82a0345cf21 ("x86/retbleed: Add call depth tracking mitigation")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: x86@...nel.org
> Cc: Jonathan Corbet <corbet@....net>
> Cc: linux-doc@...r.kernel.org
> ---
>  Documentation/admin-guide/kernel-parameters.txt |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff -- a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5364,6 +5364,14 @@
>  				       when STIBP is not available. This is
>  				       the alternative for systems which do not
>  				       have STIBP.
> +			stuff        - Enables "stuffing" mode mitigation,
> +				       which uses return thunking and call depth
> +				       tracking.  Only if effect if
> +				       CONFIG_CALL_DEPTH_TRACKING is set and
> +				       Spectre V2 mitigation mode is
> +				       "retpoline".
> +				       IBRS is fully secure mitigation but is
> +				       more costly (slower) than stuffing.

Typo:

  s/only if effect if
   /only in effect if

Other than that:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo