linux-kernel - Re: [PATCH] usb: cdnsp: : add scatter gather support for ISOC endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 19:12:32 +0800
From:   Peter Chen <peter.chen@...nel.org>
To:     Pawel Laszczak <pawell@...ence.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] usb: cdnsp: : add scatter gather support for ISOC
 endpoint

On 23-01-09 05:47:49, Pawel Laszczak wrote:
> 
> >
> >On 22-12-22 04:09:34, Pawel Laszczak wrote:
> >> Patch implements scatter gather support for isochronous endpoint.
> >> This fix is forced by 'commit e81e7f9a0eb9
> >> ("usb: gadget: uvc: add scatter gather support")'.
> >> After this fix CDNSP driver stop working with UVC class.
> >>
> >> cc: <stable@...r.kernel.org>
> >> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence
> >> USBSSP DRD Driver")
> >> Signed-off-by: Pawel Laszczak <pawell@...ence.com>
> >> ---
> >>  drivers/usb/cdns3/cdnsp-gadget.c |   2 +-
> >>  drivers/usb/cdns3/cdnsp-gadget.h |   4 +-
> >>  drivers/usb/cdns3/cdnsp-ring.c   | 110 +++++++++++++++++--------------
> >>  3 files changed, 63 insertions(+), 53 deletions(-)
> >>
> >> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c
> >> b/drivers/usb/cdns3/cdnsp-gadget.c
> >> index a8640516c895..e81dca0e62a8 100644
> >> --- a/drivers/usb/cdns3/cdnsp-gadget.c
> >> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
> >> @@ -382,7 +382,7 @@ int cdnsp_ep_enqueue(struct cdnsp_ep *pep, struct
> >cdnsp_request *preq)
> >>  		ret = cdnsp_queue_bulk_tx(pdev, preq);
> >>  		break;
> >>  	case USB_ENDPOINT_XFER_ISOC:
> >> -		ret = cdnsp_queue_isoc_tx_prepare(pdev, preq);
> >> +		ret = cdnsp_queue_isoc_tx(pdev, preq);
> >>  	}
> >>
> >>  	if (ret)
> >> diff --git a/drivers/usb/cdns3/cdnsp-gadget.h
> >> b/drivers/usb/cdns3/cdnsp-gadget.h
> >> index f740fa6089d8..e1b5801fdddf 100644
> >> --- a/drivers/usb/cdns3/cdnsp-gadget.h
> >> +++ b/drivers/usb/cdns3/cdnsp-gadget.h
> >> @@ -1532,8 +1532,8 @@ void cdnsp_queue_stop_endpoint(struct
> >cdnsp_device *pdev,
> >>  			       unsigned int ep_index);
> >>  int cdnsp_queue_ctrl_tx(struct cdnsp_device *pdev, struct
> >> cdnsp_request *preq);  int cdnsp_queue_bulk_tx(struct cdnsp_device
> >> *pdev, struct cdnsp_request *preq); -int
> >cdnsp_queue_isoc_tx_prepare(struct cdnsp_device *pdev,
> >> -				struct cdnsp_request *preq);
> >> +int cdnsp_queue_isoc_tx(struct cdnsp_device *pdev,
> >> +			struct cdnsp_request *preq);
> >
> >Why you re-name this function?
> >
> >Other changes are ok for me.
> >
> 
> The function cdnsp_queue_isoc_tx_prepare has been removed and replaced
> with cdnsp_queue_isoc_tx.  I just add declaration of this function to header file.
> Before change cdnsp_queue_isoc_tx was static function.
> 

Reviewed-by: Peter Chen <peter.chen@...nel.org>

-- 

Thanks,
Peter Chen