[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87zgarg9ul.wl-tiwai@suse.de>
Date: Mon, 09 Jan 2023 13:40:02 +0100
From: Takashi Iwai <tiwai@...e.de>
To: <yang.yang29@....com.cn>
Cc: <perex@...ex.cz>, <tiwai@...e.com>, <alsa-devel@...a-project.org>,
<linux-kernel@...r.kernel.org>, <xu.panda@....com.cn>
Subject: Re: [PATCH linux-next] ALSA: control-led: use strscpy() to instead of strncpy()
On Mon, 09 Jan 2023 12:45:51 +0100,
<yang.yang29@....com.cn> wrote:
>
> From: Xu Panda <xu.panda@....com.cn>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.
>
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com.cn>
> ---
> sound/core/control_led.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/core/control_led.c b/sound/core/control_led.c
> index f975cc85772b..c88653c205eb 100644
> --- a/sound/core/control_led.c
> +++ b/sound/core/control_led.c
> @@ -534,8 +534,7 @@ static ssize_t set_led_id(struct snd_ctl_led_card *led_card, const char *buf, si
> struct snd_ctl_elem_id id;
> int err;
>
> - strncpy(buf2, buf, len);
> - buf2[len] = '\0';
> + strncpy(buf2, buf, len + 1);
Still using strncpy()...?
thanks,
Takashi
Powered by blists - more mailing lists