linux-kernel - Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y7wOZ0tm7XiJ4Bhx@kadam>
Date:   Mon, 9 Jan 2023 15:53:59 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Philipp Hortmann <philipp.g.hortmann@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] staging: rtl8192e: Rename TSSI_13dBm, Pwr_Track and
 NumTotalRFPath

On Sun, Jan 08, 2023 at 03:09:40PM +0100, Philipp Hortmann wrote:
> On 1/3/23 09:30, Dan Carpenter wrote:
> > On Thu, Dec 29, 2022 at 05:25:46PM +0100, Philipp Hortmann wrote:
> > > Rename variable TSSI_13dBm to tssi_13dbm
> > 
> > I would probably have kept this one as-is.  It's not CamelCase, it's the
> > correct way to capitalize it.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hi Dan,
> 
> sorry for late.
> 
> No issue with keeping this variable as is. But can you tell me the rule for
> the rest of the variables in this driver?
> 
> Here just some examples: (I know that checkpatch is not always right)
> CHECK: Avoid CamelCase: <Avg_TSSI_Meas>
> CHECK: Avoid CamelCase: <TSSI_13dBm>
> CHECK: Avoid CamelCase: <Avg_TSSI_Meas_from_driver>
> 
> Are those OK as well?

You can change the others.  It's just dBm where the capitalization is
correct in the original.

https://en.wikipedia.org/wiki/DBm

(Ironically it's capitalized incorrectly in the URL, but it's probably
too late the fix the URL).

regards,
dan carpenter