linux-kernel - Re: [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 15:13:36 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Fabien Dessenne <fabien.dessenne@...s.st.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Marek Vasut <marex@...x.de>, linux-gpio@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: stm32: Fix refcount leak in stm32_pctrl_get_irq_domain

On Mon, Jan 2, 2023 at 9:25 AM Miaoqian Lin <linmq006@...il.com> wrote:

> of_irq_find_parent() returns a node pointer with refcount incremented,
> We should use of_node_put() on it when not needed anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d86f4d71e42a ("pinctrl: stm32: check irq controller availability at probe")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Patch applied!

Yours,
Linus Walleij