linux-kernel - Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588 boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 09 Jan 2023 14:27:21 +0000
From:   Christopher Obbard <chris.obbard@...labora.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marc Zyngier <maz@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCHv6 4/7] dt-bindings: arm: rockchip: add initial rk3588
 boards

> 
> 
Hi Sebastian,

> > To better match other boards from this vendor (e.g. RADXA ROCK 4)
> > 
> > would it be best to capitalise this (and obviously the model field
> > in
> > the respective DTS patches) the same?
> > 
> > So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".
> > 
> > It's also capitalised this way on the documentation website [1].
> > 
> > (I think the vendor has specifically dropped the Pi reference from
> > these boards, but I don't know why)
> > 
> > Thanks!
> > Chris
> > 
> > [1]: https://wiki.radxa.com/Rock5/5B
> 
> The current format has been requested by Radxa:
> 
> https://lore.kernel.org/all/892CB3E963AEF095+eaed7498-2324-9476-6a24-f940d62adb74@radxa.com/
> 

The comment there suggests to use "Radxa ROCK 5 Model A" and "Radxa
ROCK 5 Model B", so can we make the following changes before the next
revision, to align on the model names?

PS. I think "board" is a terrible suffix, it's almost like when people
say "PCB Board". But maybe I am missing some historical context here ?


- Patch 4: "description: Radxa Rock 5 Model A" > "description: Radxa
ROCK 5 Model A"
- Patch 4: "description: Radxa Rock 5 Model B" > "description: Radxa
ROCK 5 Model B"
- Patch 6: "Radxa Rock 5A Board" > "Radxa ROCK 5 Model A"
- Patch 7: "Radxa Rock 5B Board" > "Radxa ROCK 5 Model B"


Thanks!
Chris