linux-kernel - Re: [PATCH v6 7/8] media: i2c: add DS90UB913 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Jan 2023 17:08:37 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Andy Shevchenko <andriy.shevchenko@...el.com>
Cc:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        linux-media@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Wolfram Sang <wsa@...nel.org>,
        Luca Ceresoli <luca.ceresoli@...tlin.com>,
        Matti Vaittinen <Matti.Vaittinen@...rohmeurope.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Peter Rosin <peda@...ntia.se>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Shawn Tu <shawnx.tu@...el.com>,
        Hans Verkuil <hverkuil@...all.nl>,
        Mike Pagano <mpagano@...too.org>,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Marek Vasut <marex@...x.de>
Subject: Re: [PATCH v6 7/8] media: i2c: add DS90UB913 driver

On 09/01/2023 16:11, Andy Shevchenko wrote:
> On Mon, Jan 09, 2023 at 04:01:43PM +0200, Tomi Valkeinen wrote:
>> On 09/01/2023 15:58, Andy Shevchenko wrote:
>>> On Mon, Jan 09, 2023 at 03:55:39PM +0200, Andy Shevchenko wrote:
>>>> On Mon, Jan 09, 2023 at 02:59:01PM +0200, Tomi Valkeinen wrote:
>>>>> On 09/01/2023 13:07, Andy Shevchenko wrote:
>>>>>> On Sun, Jan 08, 2023 at 06:06:34AM +0200, Laurent Pinchart wrote:
>>>>>>> On Thu, Jan 05, 2023 at 04:03:06PM +0200, Tomi Valkeinen wrote:
> 
> ...
> 
>>>>>>>> +	gc->of_node = priv->client->dev.of_node;
>>>>>>
>>>>>> We don't have of_node anymore in gc. And if the parent device is set, you can
>>>>>> drop this line (it will work with older and newer kernels. Otherwise, use
>>>>>> fwnode.
>>>>>
>>>>> What do you mean "we don't have of_node anymore"?
>>>
>>> Just to add that you missed "gc" in the quote which is crucial to get
>>> what I meant.
>>
>> Well, the original text was just above...
> 
> Yes, but my point is that that part is crucial and since you left it out makes
> me think that you are talking about general of_node, which is of course won't
> gone any time soon :-)
> 
>>>> There is no of_node member of struct gpio_chip anymore. This will fail
>>>> to compile.
>>
>> It's in Linus' tree, but yes, now that I fetched linux-next I see it's gone.
> 
> Right. I expressed to Bart to include that change into one of the rcX, but he
> decided to go for next. Dunno how many cases like yours we may experience in
> this cycle.

Alright. Well, good that you caught this already. In the worst case we 
would have had a compilation break in the next merge window.

  Tomi