linux-kernel - Re: [PATCH v3] tracing/eprobe: no need to check for negative ret value for snprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230109101226.7f75fc0e@gandalf.local.home>
Date:   Mon, 9 Jan 2023 10:12:26 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc:     Quanfa Fu <quanfafu@...il.com>, linux-kernel@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v3] tracing/eprobe: no need to check for negative ret
 value for snprintf

On Mon, 9 Jan 2023 23:59:13 +0900
Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> On Mon,  9 Jan 2023 12:06:25 +0800
> Quanfa Fu <quanfafu@...il.com> wrote:
> 
> > No need to check for negative return value from snprintf() as the
> > code does not return negative values.
> >   
> 
> Thanks for simplifying, this looks good to me.
> 
> Acked-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Masami, do you want to take it into the probes branch, or do you want me to
take it into the tracing branch?

-- Steve


> 
> > Signed-off-by: Quanfa Fu <quanfafu@...il.com>
> >