linux-kernel - Re: [PATCH] pr_info("I changed uvcvideo driver in the Linux Kernel\n");

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a440a001-e9d8-ff8a-32c0-68df328d1c89@collabora.com>
Date:   Tue, 10 Jan 2023 18:01:00 +0100
From:   Andrzej Pietrasiewicz <andrzej.p@...labora.com>
To:     Xiaxi Shen <shenxiaxi26@...il.com>
Cc:     laurent.pinchart@...asonboard.com, mchehab@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pr_info("I changed uvcvideo driver in the Linux
 Kernel\n");

Hi,

W dniu 10.01.2023 o 00:39, Xiaxi Shen pisze:
> Hi Andrzej,
> 
> Thanks for your advice.
> It is my first time to send a patch, I will definitely check my explanation 
> according to relevant guidelines before my future submission

I recommend reading:

Documentation/process/*.

Regards,

Andrzej

> 
> Yours sincerely,
> Xiaxi Shen
> 
> Andrzej Pietrasiewicz <andrzej.p@...labora.com <mailto:andrzej.p@...labora.com>> 
> 于2023年1月9日周一 08:14写道：
> 
>     Hello XiaxiShen,
> 
>       From Documentation/process/researcher-guidelines.rst:
> 
>     "The Linux kernel community expects that everyone interacting with the
>     project is participating in good faith to make Linux better."
> 
>     Please explain how your patch will make Linux better. "I added a pr_info()
>     which emits information unrelated to work of the driver" is not enough of an
>     explanation.
> 
>     Failing to do so and to adhere to the expectation quoted above
>     you risk any patches to the kernel submitted by you being disregarded.
> 
>     Andrzej
> 
>     W dniu 30.12.2022 o 04:46, XiaxiShen pisze:
>      > Signed-off-by: XiaxiShen <shenxiaxi26@...il.com
>     <mailto:shenxiaxi26@...il.com>>
>      > ---
>      >   drivers/media/usb/uvc/uvc_driver.c | 2 ++
>      >   1 file changed, 2 insertions(+)
>      >
>      > diff --git a/drivers/media/usb/uvc/uvc_driver.c
>     b/drivers/media/usb/uvc/uvc_driver.c
>      > index e4bcb5011360..60778a5a2b4e 100644
>      > --- a/drivers/media/usb/uvc/uvc_driver.c
>      > +++ b/drivers/media/usb/uvc/uvc_driver.c
>      > @@ -2082,6 +2082,8 @@ static int uvc_probe(struct usb_interface *intf,
>      >               (const struct uvc_device_info *)id->driver_info;
>      >       int function;
>      >       int ret;
>      > +     pr_info("I changed uvcvideo driver in the Linux Kernel\n");
>      > +
>      >
>      >       /* Allocate memory for the device and initialize it. */
>      >       dev = kzalloc(sizeof(*dev), GFP_KERNEL);
>