linux-kernel - Re: [PATCH] bit_spinlock: Include <asm/processor.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4aa7f0d-50a9-b5e0-e980-1e8e779b48bc@wanadoo.fr>
Date:   Tue, 10 Jan 2023 19:08:33 +0100
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Vineet Gupta <vgupta@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dan Carpenter <error27@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-snps-arc@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] bit_spinlock: Include <asm/processor.h>

Le 10/01/2023 à 08:19, Vineet Gupta a écrit :
> 
> On 1/8/23 11:04, Christophe JAILLET wrote:
>> In an attempt to simplify some includes in <include/dcache.h>, it
>> appeared, when compiling fs/ecryptfs/dentry.c, that 
>> <linux/bit_spinlock.h>
>> was relying on other includes to get the definition of cpu_relax().
>> (see [1])
>>
>> It broke on arc.
> 
> It its just ARC that broke, maybe we can do something there ?

Hi,

It is all what build-bots have spotted so far :)

I don't think that "fixing" it in ARC is the right approach, unless I 
missed something.

<linux/bit_spinlock.h> does use cpu_relax(), so it should include what 
is need for that, and not rely on other black magic.

CJ

> 
>> Include <asm/processor.h> in <linux/bit_spinlock.h> to fix the issue.
>> This will help remove some un-needed includes from <include/dcache.h>.
>>
>> [1]: https://lore.kernel.org/all/202301082130.LXMj5qkD-lkp@intel.com/
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
>> ---
>> Not sure who to send this to.
>> get_maintainer.pl is of no help, and the file is untouched from a too 
>> long
>> time.
>>
>> Greg? Dan? Any pointer?
>> ---
>>   include/linux/bit_spinlock.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/bit_spinlock.h b/include/linux/bit_spinlock.h
>> index bbc4730a6505..d0fd2a7afca2 100644
>> --- a/include/linux/bit_spinlock.h
>> +++ b/include/linux/bit_spinlock.h
>> @@ -2,6 +2,7 @@
>>   #ifndef __LINUX_BIT_SPINLOCK_H
>>   #define __LINUX_BIT_SPINLOCK_H
>> +#include <asm/processor.h>
>>   #include <linux/kernel.h>
>>   #include <linux/preempt.h>
>>   #include <linux/atomic.h>
> 
>