linux-kernel - Re: [PATCH 1/2] x86/pci: Simplify is_mmconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230110181202.GA1591198@bhelgaas>
Date:   Tue, 10 Jan 2023 12:12:02 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     linux-pci@...r.kernel.org, Kan Liang <kan.liang@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        David E Box <david.e.box@...el.com>,
        Yunying Sun <yunying.sun@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Hans de Goede <hdegoede@...hat.com>,
        Florent DELAHAYE <linuxkernelml@...ead.fr>,
        Konrad J Hambrick <kjhambrick@...il.com>,
        Matt Hansen <2lprbe78@...k.com>,
        Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        Benoit Grégoire <benoitg@...us.ca>,
        Werner Sembach <wse@...edocomputers.com>,
        mumblingdrunkard@...tonmail.com, linux-kernel@...r.kernel.org,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 1/2] x86/pci: Simplify is_mmconf_reserved() messages

On Tue, Jan 10, 2023 at 10:07:39AM -0800, Dan Williams wrote:
> Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@...gle.com>
> > 
> > is_mmconf_reserved() takes a "with_e820" parameter that only determines the
> > message logged if it finds the MMCONFIG region is reserved.  Pass the
> > message directly, which will simplify a future patch that adds a new way of
> > looking for that reservation.  No functional change intended.
> > 
> > Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> > ---
> >  arch/x86/pci/mmconfig-shared.c | 13 +++++++------
> >  1 file changed, 7 insertions(+), 6 deletions(-)
> > 
> > diff --git a/arch/x86/pci/mmconfig-shared.c b/arch/x86/pci/mmconfig-shared.c
> > index 758cbfe55daa..cd16bef5f2d9 100644
> > --- a/arch/x86/pci/mmconfig-shared.c
> > +++ b/arch/x86/pci/mmconfig-shared.c
> > @@ -446,13 +446,12 @@ typedef bool (*check_reserved_t)(u64 start, u64 end, enum e820_type type);
> >  
> >  static bool __ref is_mmconf_reserved(check_reserved_t is_reserved,
> >  				     struct pci_mmcfg_region *cfg,
> > -				     struct device *dev, int with_e820)
> > +				     struct device *dev, char *method)
> 
> @method could be 'const char *', but either way:

Of course, thanks!  Folded in.