linux-kernel - Re: [PATCH v5 3/3] fanotify, audit: Allow audit to use the full permission event response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y72vSB+dEgD4HMCN@madcap2.tricolour.ca>
Date:   Tue, 10 Jan 2023 13:32:40 -0500
From:   Richard Guy Briggs <rgb@...hat.com>
To:     Steve Grubb <sgrubb@...hat.com>
Cc:     Jan Kara <jack@...e.cz>, linux-api@...r.kernel.org,
        Amir Goldstein <amir73il@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux-Audit Mailing List <linux-audit@...hat.com>,
        linux-fsdevel@...r.kernel.org, Eric Paris <eparis@...isplace.org>
Subject: Re: [PATCH v5 3/3] fanotify, audit: Allow audit to use the full
 permission event response

On 2023-01-10 10:26, Steve Grubb wrote:
> Hello Richard,
> 
> On Monday, January 9, 2023 10:08:04 PM EST Richard Guy Briggs wrote:
> > When I use an application that expected the old API, meaning it simply
> > does:
> > > 
> > > response.fd = metadata->fd;
> > > response.response = reply;
> > > close(metadata->fd);
> > > write(fd, &response, sizeof(struct fanotify_response));
> > > 
> > > I get access denials. Every time. If the program is using the new API and
> > > sets FAN_INFO, then it works as expected. I'll do some more testing but I
> > > think there is something wrong in the compatibility path.
> > 
> > I'll have a closer look, because this wasn't the intended behaviour.
> 
> I have done more testing. I think what I saw might have been caused by a 
> stale selinux label (label exists, policy is deleted). With selinux in 
> permissive mode it's all working as expected - both old and new API.

Ah good, thank you.

> -Steve

- RGB

--
Richard Guy Briggs <rgb@...hat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635