linux-kernel - Re: [PATCH v2 1/2] iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Jan 2023 07:09:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hugo Villeneuve <hugo@...ovil.com>, hvilleneuve@...onoff.com,
        jic23@...nel.org, lars@...afoo.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        hugo@...ovil.com
Subject: Re: [PATCH v2 1/2] iio: adc: ti-ads7924: add Texas Instruments
 ADS7924 driver

Hi Hugo,

I love your patch! Yet something to improve:

[auto build test ERROR on bfcae956d9b50ea0e221cefc171604c569017d7e]

url:    https://github.com/intel-lab-lkp/linux/commits/Hugo-Villeneuve/iio-adc-ti-ads7924-add-Texas-Instruments-ADS7924-driver/20230111-000513
base:   bfcae956d9b50ea0e221cefc171604c569017d7e
patch link:    https://lore.kernel.org/r/20230110160124.3853593-2-hugo%40hugovil.com
patch subject: [PATCH v2 1/2] iio: adc: ti-ads7924: add Texas Instruments ADS7924 driver
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b462acbd9ff0d0b52029ea3d060693cda131836d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Hugo-Villeneuve/iio-adc-ti-ads7924-add-Texas-Instruments-ADS7924-driver/20230111-000513
        git checkout b462acbd9ff0d0b52029ea3d060693cda131836d
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/adc/ti-ads7924.c: In function 'ads7924_set_conv_mode':
>> drivers/iio/adc/ti-ads7924.c:313:30: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     313 |                 mode_field = FIELD_PREP(ADS7924_MODECNTRL_MODE_MASK,
         |                              ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/FIELD_PREP +313 drivers/iio/adc/ti-ads7924.c

   300	
   301	static int ads7924_set_conv_mode(struct ads7924_data *data, int mode)
   302	{
   303		int ret;
   304		unsigned int mode_field;
   305		struct device *dev = data->dev;
   306	
   307		/*
   308		 * When switching between modes, be sure to first select the Awake mode
   309		 * and then switch to the desired mode. This procedure ensures the
   310		 * internal control logic is properly synchronized.
   311		 */
   312		if (mode != ADS7924_MODECNTRL_IDLE) {
 > 313			mode_field = FIELD_PREP(ADS7924_MODECNTRL_MODE_MASK,
   314						ADS7924_MODECNTRL_AWAKE);
   315	
   316			ret = regmap_update_bits(data->regmap, ADS7924_MODECNTRL_REG,
   317						 ADS7924_MODECNTRL_MODE_MASK,
   318						 mode_field);
   319			if (ret) {
   320				dev_warn(dev, "failed to set awake mode (%pe)\n",
   321					 ERR_PTR(ret));
   322				return ret;
   323			}
   324		}
   325	
   326		mode_field = FIELD_PREP(ADS7924_MODECNTRL_MODE_MASK, mode);
   327	
   328		ret = regmap_update_bits(data->regmap, ADS7924_MODECNTRL_REG,
   329					 ADS7924_MODECNTRL_MODE_MASK, mode_field);
   330		if (ret)
   331			dev_warn(dev, "failed to set mode %d (%pe)\n", mode,
   332				 ERR_PTR(ret));
   333	
   334		return ret;
   335	}
   336	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (245810 bytes)