[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d8a7e477-f612-19cb-8573-5cc0449df0fa@linaro.org>
Date: Tue, 10 Jan 2023 23:13:35 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>,
linux-arm-msm@...r.kernel.org, andersson@...nel.org,
agross@...nel.org, krzysztof.kozlowski@...aro.org
Cc: marijn.suijten@...ainline.org, Georgi Djakov <djakov@...nel.org>,
Evan Green <evgreen@...omium.org>,
Jun Nie <jun.nie@...aro.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Brian Masney <masneyb@...tation.org>,
Yassine Oudjana <y.oudjana@...tonmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/10] interconnect: qcom: rpm: make QoS INVALID
default, separate out driver data
On 10/01/2023 13:21, Konrad Dybcio wrote:
> +#define NOC_QOS_MODE_INVALID_VAL -1
> +#define NOC_QOS_MODE_FIXED_VAL 0x0
> +#define NOC_QOS_MODE_BYPASS_VAL 0x2
The basic fix you are applying here makes sense to me.
But why bother with an additional _VAL defintion, you have your enum.
+enum qos_mode {
+ NOC_QOS_MODE_INVALID = 0,
+ NOC_QOS_MODE_FIXED,
+ NOC_QOS_MODE_BYPASS,
+};
---
bod
Powered by blists - more mailing lists