linux-kernel - Re: [PATCH] ASoC: dt-bindings: simple-card: Document simple-audio-card,plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0ad7a4e-a8af-77d4-09e4-3717041677e7@arm.com>
Date:   Tue, 10 Jan 2023 13:53:29 +0530
From:   Mohammad Faiz Abbas Rizvi <faiz.abbas@....com>
To:     Rob Herring <robh@...nel.org>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        alsa-devel@...a-project.org, broonie@...nel.org,
        lgirdwood@...il.com, krzysztof.kozlowski+dt@...aro.org,
        kuninori.morimoto.gx@...esas.com, Anurag.Koul@....com,
        Deepak.Pandey@....com
Subject: Re: [PATCH] ASoC: dt-bindings: simple-card: Document
 simple-audio-card,plat

Hi Rob,

On 1/8/2023 10:07 PM, Rob Herring wrote:
> On Thu, Jan 05, 2023 at 09:33:46PM +0530, Faiz Abbas wrote:
>> The simple card driver has support for adding cpu, codec and platform
>> nodes with the simple-audio-card prefix. Add documentation for the plat
>> binding.
> Another node, is it still 'simple card'?

This behavior already exists in the driver. I am just documenting what already exists.

>> Signed-off-by: Faiz Abbas <faiz.abbas@....com>
>> ---
>>  .../bindings/sound/simple-card.yaml           | 23 +++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/simple-card.yaml b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> index ed19899bc94b..fa67c76d4dbb 100644
>> --- a/Documentation/devicetree/bindings/sound/simple-card.yaml
>> +++ b/Documentation/devicetree/bindings/sound/simple-card.yaml
>> @@ -205,6 +205,8 @@ patternProperties:
>>      $ref: "#/definitions/dai"
>>    "^simple-audio-card,codec(@[0-9a-f]+)?$":
>>      $ref: "#/definitions/dai"
>> +  "^simple-audio-card,plat(@[0-9a-f]+)?$":
> What does 'plat' mean?

plat means platform. I'll make that clear in the patch description in v2.


> Don't continue the 'simple-audio-card,' prefix.

The implementation already exists. Its just not documented here.


>> +    $ref: "#/definitions/dai"
>>
>>    "^simple-audio-card,dai-link(@[0-9a-f]+)?$":
>>      description: |
>> @@ -285,6 +287,27 @@ examples:
>>          };
>>      };
>>
>> +#-------------------------------
>> +# single DAI link with platform
>> +#-------------------------------
> Really need another example for 1 simple node?

I'll remove the example if that makes it easier.

Thanks,

Faiz

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.