linux-kernel - Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Spectre x360 13-aw0xxx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k01ueqga.wl-tiwai@suse.de>
Date:   Tue, 10 Jan 2023 09:36:37 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Luka Guzenko <l.guzenko@....de>
Cc:     tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable mute/micmute LEDs on HP Spectre x360 13-aw0xxx

On Tue, 10 Jan 2023 00:58:40 +0100,
Luka Guzenko wrote:
> 
> The HP Spectre x360 13-aw0xxx devices use the ALC285 codec with GPIO 0x04
> controlling the micmute LED and COEF 0x0b index 8 controlling the mute LED.
> A quirk was added to make these work as well as a fixup entry.
> 
> Signed-off-by: Luka Guzenko <l.guzenko@....de>
> ---
>  sound/pci/hda/patch_realtek.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3794b522c222..6a76a2eddd3c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4644,6 +4644,16 @@ static void alc285_fixup_hp_coef_micmute_led(struct hda_codec *codec,
>  	}
>  }
> 
> +static void alc285_fixup_hp_gpio_micmute_led(struct hda_codec *codec,
> +				const struct hda_fixup *fix, int action)
> +{
> +	struct alc_spec *spec = codec->spec;
> +
> +	if (action != HDA_FIXUP_ACT_PRE_PROBE)
> +		spec->micmute_led_polarity = 1;

Is this condition correct?  It's usually other way round; a flag is
set up only once at parsing.


thanks,

Takashi