linux-kernel - Re: [PATCH 6/7] dm-zone: use generic helpers to calculate offset from zone start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8326ea7-a354-e627-195f-dcd02b13accc@samsung.com>
Date:   Tue, 10 Jan 2023 10:06:21 +0100
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Christoph Hellwig <hch@....de>
CC:     <axboe@...nel.dk>, <kernel@...kajraghav.com>,
        <linux-kernel@...r.kernel.org>, <hare@...e.de>,
        <bvanassche@....org>, <snitzer@...nel.org>, <dm-devel@...hat.com>,
        <damien.lemoal@...nsource.wdc.com>,
        <linux-nvme@...ts.infradead.org>, <linux-block@...r.kernel.org>,
        <gost.dev@...sung.com>, Luis Chamberlain <mcgrof@...nel.org>,
        Johannes Thumshirn <johannes.thumshirn@....com>
Subject: Re: [PATCH 6/7] dm-zone: use generic helpers to calculate offset
 from zone start

On 2023-01-10 07:57, Christoph Hellwig wrote:
> On Fri, Jan 06, 2023 at 09:33:16AM +0100, Pankaj Raghav wrote:
>> Use the bdev_offset_from_zone_start() helper function to calculate
>> the offset from zone start instead of open coding.
>>
>> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
>> Reviewed-by: Luis Chamberlain <mcgrof@...nel.org>
>> Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
>> Reviewed-by: Bart Van Assche <bvanassche@....org>
>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
>> Reviewed-by: Mike Snitzer <snitzer@...nel.org>
>> ---
>>  drivers/md/dm-zone.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/md/dm-zone.c b/drivers/md/dm-zone.c
>> index 3dafc0e8b7a9..ac6fc1293d41 100644
>> --- a/drivers/md/dm-zone.c
>> +++ b/drivers/md/dm-zone.c
>> @@ -390,7 +390,8 @@ static bool dm_zone_map_bio_begin(struct mapped_device *md,
>>  	case REQ_OP_WRITE_ZEROES:
>>  	case REQ_OP_WRITE:
>>  		/* Writes must be aligned to the zone write pointer */
>> -		if ((clone->bi_iter.bi_sector & (zsectors - 1)) != zwp_offset)
>> +		if (bdev_offset_from_zone_start(md->disk->part0,
>> +						clone->bi_iter.bi_sector) != zwp_offset)
> 
> I can't see how this actually cleans antyhing up, while it does add an
> overly long line.
>
While I do agree with the overly long line comment, I feel it makes the
intent more clear, as it is easy to overlook this math operation.

>>  		if (clone->bi_status == BLK_STS_OK &&
>>  		    bio_op(clone) == REQ_OP_ZONE_APPEND) {
>>  			orig_bio->bi_iter.bi_sector +=
>> -				clone->bi_iter.bi_sector & mask;
>> +				bdev_offset_from_zone_start(disk->part0, clone->bi_iter.bi_sector);
> 
> Same here.