linux-kernel - Re: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2023 18:17:52 +0900
From:   OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Pali Rohár <pali@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fat: Fix return value of vfat_bad_char() and
 vfat_replace_char() functions

Pali Rohár <pali@...nel.org> writes:

> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Rohár <pali@...nel.org>

Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

> ---
>  fs/fat/namei_vfat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>  
>  /* Characters that are undesirable in an MS-DOS file name */
>  
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
>  {
>  	return (w < 0x0020)
>  	    || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
>  	    || (w == '\\');
>  }
>  
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
>  {
>  	return (w == '[') || (w == ']') || (w == ';') || (w == ',')
>  	    || (w == '+') || (w == '=');

-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>