[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <161fdffccb78fca2f16f1f5c78390420f60817b3.camel@redhat.com>
Date: Tue, 10 Jan 2023 13:49:28 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Michael Walle <michael@...le.cc>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Jose Abreu <Jose.Abreu@...opsys.com>,
Sergey Shtylyov <s.shtylyov@....ru>,
Wei Fang <wei.fang@....com>,
Shenwei Wang <shenwei.wang@....com>,
Clark Wang <xiaoning.wang@....com>,
NXP Linux Team <linux-imx@....com>,
Sean Wang <sean.wang@...iatek.com>,
Landen Chao <Landen.Chao@...iatek.com>,
DENG Qingfang <dqfext@...il.com>,
Florian Fainelli <f.fainelli@...il.com>,
Vladimir Oltean <olteanv@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-renesas-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, Andrew Lunn <andrew@...n.ch>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next v3 01/11] net: mdio: Add dedicated C45 API to
MDIO bus drivers
On Tue, 2023-01-10 at 12:16 +0100, Paolo Abeni wrote:
> On Mon, 2023-01-09 at 16:30 +0100, Michael Walle wrote:
> > diff --git a/include/linux/phy.h b/include/linux/phy.h
> > index 6378c997ded5..65844f0a7fb3 100644
> > --- a/include/linux/phy.h
> > +++ b/include/linux/phy.h
> > @@ -364,6 +364,11 @@ struct mii_bus {
> > int (*read)(struct mii_bus *bus, int addr, int regnum);
> > /** @write: Perform a write transfer on the bus */
> > int (*write)(struct mii_bus *bus, int addr, int regnum, u16 val);
> > + /** @read: Perform a C45 read transfer on the bus */
>
> Minor nit: s/@...d/@...d_c45/
>
> > + int (*read_c45)(struct mii_bus *bus, int addr, int devnum, int regnum);
> > + /** @write: Perform a C45 write transfer on the bus */
>
> Mutatis mutandis, same thing here.
Otherwise the series LGTM. I think it would be preferable avoiding
reposting a largish series like this for such a minor change. I think
the series can be merged as-is and the above can be addressed with a
follow-up patch.
Cheers,
Paolo
Powered by blists - more mailing lists