linux-kernel - Re: [PATCH 1/1] habanalabs: remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFCwf11sCX2k_kaKEPjjc5TcdWi+TK1gQ90XPFfgM3bBpLm91g@mail.gmail.com>
Date:   Tue, 10 Jan 2023 15:34:45 +0200
From:   Oded Gabbay <ogabbay@...nel.org>
To:     XU pengfei <xupengfei@...china.com>
Cc:     arnd@...db.de, gregkh@...uxfoundation.org, osharabi@...ana.ai,
        obitton@...ana.ai, dhirschfeld@...ana.ai, mhaimovski@...ana.ai,
        rkatta@...ana.ai, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] habanalabs: remove unnecessary (void*) conversions

On Tue, Jan 10, 2023 at 12:35 PM XU pengfei <xupengfei@...china.com> wrote:
>
> data is a void * type and does not require a cast.
>
> Signed-off-by: XU pengfei <xupengfei@...china.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu.c b/drivers/misc/habanalabs/common/mmu/mmu.c
> index 2c1005f74cf4..a42ae8bc61e8 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu.c
> @@ -781,7 +781,7 @@ static void mmu_dma_mem_free_from_chunk(struct gen_pool *pool,
>                                         struct gen_pool_chunk *chunk,
>                                         void *data)
>  {
> -       struct hl_device *hdev = (struct hl_device *)data;
> +       struct hl_device *hdev = data;
>
>         hl_asic_dma_free_coherent(hdev, (chunk->end_addr - chunk->start_addr) + 1,
>                                         (void *)chunk->start_addr, chunk->phys_addr);
> --
> 2.18.2
>

Reviewed-by: Oded Gabbay <ogabbay@...nel.org>
Applied to -next.
Thanks,
Oded