linux-kernel - Re: [PATCH v2 4/7] arm64: dts: qcom: Add msm8939 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde66389-619b-771d-1956-43059f8e4d5a@linaro.org>
Date:   Tue, 10 Jan 2023 13:42:21 +0000
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        agross@...nel.org, andersson@...nel.org, konrad.dybcio@...aro.org,
        djakov@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        benl@...areup.com, shawn.guo@...aro.org, fabien.parent@...aro.org,
        leo.yan@...aro.org, dmitry.baryshkov@...aro.org,
        Jun Nie <jun.nie@...aro.org>,
        James Willcox <jwillcox@...areup.com>,
        Joseph Gates <jgates@...areup.com>,
        Max Chen <mchen@...areup.com>, Zac Crosby <zac@...areup.com>,
        Vincent Knecht <vincent.knecht@...loo.org>,
        Stephan Gerhold <stephan@...hold.net>
Subject: Re: [PATCH v2 4/7] arm64: dts: qcom: Add msm8939 SoC

On 10/01/2023 13:24, Krzysztof Kozlowski wrote:
> On 10/01/2023 14:14, Bryan O'Donoghue wrote:
>> On 03/01/2023 09:14, Krzysztof Kozlowski wrote:
>>> ../arch/arm64/boot/dts/qcom/msm8939.dtsi:1825.23-1842.5: Warning
>>> (simple_bus_reg): /soc@...mc@...4000: simple-bus unit address format
>>> error, expected "7824900
>>
>> For the record the driver consuming this dt entry requires the host regs
>> to come first followed by the core
>>
>> sdhc_1: mmc@...4000 {
>>           compatible = "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4";
>>           reg = <0x07824900 0x11c>, <0x07824000 0x800>;
>>           reg-names = "hc", "core";
>> }
>>
>> If I change this and the msm8916 to
> 
> That's not the solution. The warning is saying that unit address does
> not match your reg. You need to correct unit address.
> 
> Best regards,
> Krzysztof
> 

Is it not the case that the unit-address should match the first reg and 
that the first reg should also be the lowest address ?

---
bod