linux-kernel - Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230110142109.gphhirh7jo67br6x@revolver>
Date:   Tue, 10 Jan 2023 14:21:15 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     SeongJae Park <sj@...nel.org>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>
Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in
 mas_wr_store_setup()

* SeongJae Park <sj@...nel.org> [230109 18:43]:
> Hi Andrew,
> 
> On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> > On Mon,  9 Jan 2023 19:22:48 +0000 SeongJae Park <sj@...nel.org> wrote:
> > 
> > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> > > 
> > > > If an invalidated maple state is encountered during write, reset the
> > > > maple state to MAS_START.  This will result in a re-walk of the tree to
> > > > the correct location for the write.
> > 
> > Can we think of a Fixes: for this?

It wasn't really an issue until I wrote the vma iterator store
function.

You can put this before (mm-unstable git id..)
9df3d25a97ec ("mm: expand vma iterator interface")

> > 
> > > > Link: https://lore.kernel.org/all/20230107020126.1627-1-sj@kernel.org/
> > > > Reported-by: SeongJae Park <sj@...nel.org>
> > > > Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> > > 
> > > Tested-by: SeongJae Park <sj@...nel.org>
> > > 
> > > I confirmed this patch fixes the boot failure issue.  Nevertheless, the 'make
> > > install' issue on my system is still not fixed.
> > 
> > Is this a mainline issue or an mm-unstable issue?
> 
> It's mm-unstable issue:
> https://lore.kernel.org/linux-mm/20230107023954.1841-1-sj@kernel.org/

Yes, just mm-unstable.