linux-kernel - Re: [PATCHv8 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2023 15:41:36 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Marc Zyngier <maz@...nel.org>, Jagan Teki <jagan@...eble.ai>,
        Linus Walleij <linus.walleij@...aro.org>,
        Christopher Obbard <chris.obbard@...labora.com>,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Kever Yang <kever.yang@...k-chips.com>, kernel@...labora.com,
        Yifeng Zhao <yifeng.zhao@...k-chips.com>,
        Elaine Zhang <zhangqing@...k-chips.com>,
        Sugar Zhang <sugar.zhang@...k-chips.com>
Subject: Re: [PATCHv8 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC

Hi,

On Tue, Jan 10, 2023 at 02:32:29PM +0100, Heiko Stübner wrote:
> Am Dienstag, 10. Januar 2023, 13:17:54 CET schrieb Sebastian Reichel:
> > Hi,
> > 
> > On Tue, Jan 10, 2023 at 12:47:23PM +0100, Heiko Stübner wrote:
> > > Hi Sebastian,
> > > 
> > > Am Montag, 9. Januar 2023, 16:57:57 CET schrieb Sebastian Reichel:
> > > > From: Kever Yang <kever.yang@...k-chips.com>
> > > > 
> > > > This initial version supports CPU, dma, interrupts, timers, UART and
> > > > SDHCI (everything necessary to boot Linux on this system on chip) as
> > > > well as Ethernet, I2C, PWM and SPI.
> > > > 
> > > > The DT is split into rk3588 and rk3588s, which is a reduced version
> > > > (i.e. with less peripherals) of the former.
> > > > 
> > > > Signed-off-by: Yifeng Zhao <yifeng.zhao@...k-chips.com>
> > > > Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> > > > Signed-off-by: Sugar Zhang <sugar.zhang@...k-chips.com>
> > > > Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> > > > [rebase, squash and reword commit message]
> > > 
> > > I guess that means the list of Rockchip Signed-off-by lines above come
> > > from the squashed patches?
> > > 
> > > If so, I guess I should add Co-Developed-by lines for them, as right now
> > > the list is incorrect (author should be first, then everyone through
> > > whose hands a patch went)
> > > 
> > > Meaning I can add those Co-Developed-by lines, so no need to resend,
> > > I'm just verifying what I assume about the lines :-)
> > 
> > Yes, those are SoB lines from squashed downstream commits.
> 
> so I've made the block into 
> Co-Developed-by: Yifeng Zhao <yifeng.zhao@...k-chips.com>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@...k-chips.com>
> Co-Developed-by: Elaine Zhang <zhangqing@...k-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> Co-Developed-by: Sugar Zhang <sugar.zhang@...k-chips.com>
> Signed-off-by: Sugar Zhang <sugar.zhang@...k-chips.com>
> Signed-off-by: Kever Yang <kever.yang@...k-chips.com>
> [rebase, squash and reword commit message]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> 
> and will apply that if you don't shout in the next hour or so :-)

LGTM.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)