linux-kernel - Re: [PATCH v4 07/12] riscv: dts: allwinner: Add Sipeed Lichee RV devicetrees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y72LDlIOYo/I8dii@aptenodytes>
Date:   Tue, 10 Jan 2023 16:58:06 +0100
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Samuel Holland <samuel@...lland.org>
Cc:     Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Jisheng Zhang <jszhang@...nel.org>,
        linux-riscv@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        Andre Przywara <andre.przywara@....com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor@...nel.org>, linux-kernel@...r.kernel.org,
        Heiko Stuebner <heiko@...ech.de>,
        Palmer Dabbelt <palmer@...osinc.com>
Subject: Re: [PATCH v4 07/12] riscv: dts: allwinner: Add Sipeed Lichee RV
 devicetrees

Hi Samuel,

On Sun 08 Jan 23, 12:42, Samuel Holland wrote:
> Hi Paul,
> 
> On 1/5/23 07:55, Paul Kocialkowski wrote:
> > Hi Samuel,
> > 
> > On Sat 31 Dec 22, 17:38, Samuel Holland wrote:
> >> Sipeed manufactures a "Lichee RV" system-on-module, which provides a
> >> minimal working system on its own, as well as a few carrier boards. The
> >> "Dock" board provides audio, USB, and WiFi. The "86 Panel" additionally
> >> provides 100M Ethernet and a built-in display panel.
> >>
> >> The 86 Panel repurposes the USB ID and VBUS detection GPIOs for its RGB
> >> panel interface, since the USB OTG port is inaccessible inside the case.
> > 
> > Looks like the panel-enabled variants would better be described as device-tree
> > overlays as they are not specific devices but are peripheral extensions.
> > 
> > What do you think?
> 
> I don't agree. The Lichee RV 86 Panel is sold as a complete unit, with
> the SoM+board and LCD pre-assembled inside a case. It is not possible to
> purchase the board without a panel, so the panel-enabled variants are
> the only variants.

Oh my bad, I didn't go as far as actually checking what it looks like.
So yeah if it's an individual device on its own I agree it deserves its
own dedicated device-tree.

Cheers,

Paul


-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)