linux-kernel - Re: [PATCH v3] usb: gadget: add WebUSB landing page support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2023 11:09:05 -0500
From:   Alan Stern <stern@...land.harvard.edu>
To:     Andrzej Pietrasiewicz <andrzej.p@...labora.com>
Cc:     Jó Ágila Bitsch <jgilab@...il.com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v3] usb: gadget: add WebUSB landing page support

On Tue, Jan 10, 2023 at 02:28:55PM +0100, Andrzej Pietrasiewicz wrote:
> Hi Jó,
> 
> W dniu 10.01.2023 o 00:19, Jó Ágila Bitsch pisze:

> > > > +                     buf[1] = /* WEBUSB_URL*/ 3;
> > > 
> > > Why not #define WEBUSB_URL?
> > 
> > in a previous iteration, I had that exact #define in place, right
> > above. However, another reviewer found it pointless. Maybe I should
> > instead put the define into include/uapi/linux/usb/ch9.h
> > 
> 
> Hmm. ch9.h had been called ch9.h for a reason. It corresponded to Chapter 9 of
> the USB spec. Adding to it something that by design is outside the spec might
> not be what we want. But I don't know.

It wouldn't hurt to create a new file: include/uapi/linux/usb/webusb.h.

Alan Stern