linux-kernel - Re: [PATCH 2/6] composefs: Add on-disk layout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16f071eb34083b6248dd50b204e8f9979b091647.camel@redhat.com>
Date:   Tue, 10 Jan 2023 17:19:25 +0100
From:   Alexander Larsson <alexl@...hat.com>
To:     Brian Masney <bmasney@...hat.com>
Cc:     linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        gscrivan@...hat.com
Subject: Re: [PATCH 2/6] composefs: Add on-disk layout

On Thu, 2023-01-05 at 10:55 -0500, Brian Masney wrote:
> On Mon, Nov 28, 2022 at 12:16:23PM +0100, Alexander Larsson wrote:
> > This commit adds the on-disk layout header file of composefs.
> > 
> > Signed-off-by: Alexander Larsson <alexl@...hat.com>
> > Signed-off-by: Giuseppe Scrivano <gscrivan@...hat.com>
> 
> Add Co-Developed-By: Giuseppe ... ?
> 
> Full disclosure: I'm not a file system developer but I'll attempt to
> help with the review of this series.
> 

Thanks. I did various changes to the github repo based on your review,
here are the outstanding comments:

> 
> > +struct cfs_header_s {
> > +       u8 version;
> > +       u8 unused1;
> > +       u16 unused2;
> > +
> > +       u32 magic;
> 
> Should the magic number appear first?

I don't think so, the version number is essentially part of the full
magic string.
> 

> 
-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
=-=-=
 Alexander Larsson                                            Red Hat,
Inc 
       alexl@...hat.com            alexander.larsson@...il.com 
He's a notorious vegetarian filmmaker who knows the secret of the alien
invasion. She's an artistic tomboy nun married to the Mob. They fight 
crime!