linux-kernel - Re: [RESEND v4 5/5] PCI: endpoint: Use link_up() callback in place of LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 00:10:53 +0800
From:   kernel test robot <lkp@...el.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        kishon@...nel.org, lpieralisi@...nel.org, bhelgaas@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, kw@...ux.com, robh@...nel.org,
        vidyas@...dia.com, vigneshr@...com,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Subject: Re: [RESEND v4 5/5] PCI: endpoint: Use link_up() callback in place
 of LINK_UP notifier

Hi Manivannan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on helgaas-pci/for-linus linus/master v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Manivannan-Sadhasivam/PCI-dra7xx-Use-threaded-IRQ-handler-for-dra7xx-pcie-main-IRQ/20230111-194541
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20230111114059.6553-6-manivannan.sadhasivam%40linaro.org
patch subject: [RESEND v4 5/5] PCI: endpoint: Use link_up() callback in place of LINK_UP notifier
config: microblaze-randconfig-r033-20230110
compiler: microblaze-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/48c63425d8d91d9240f5bc00fcf3f2b35910c343
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Manivannan-Sadhasivam/PCI-dra7xx-Use-threaded-IRQ-handler-for-dra7xx-pcie-main-IRQ/20230111-194541
        git checkout 48c63425d8d91d9240f5bc00fcf3f2b35910c343
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/pci/endpoint/functions/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/endpoint/functions/pci-epf-test.c:829:5: warning: no previous prototype for 'pci_epf_test_link_up' [-Wmissing-prototypes]
     829 | int pci_epf_test_link_up(struct pci_epf *epf)
         |     ^~~~~~~~~~~~~~~~~~~~


vim +/pci_epf_test_link_up +829 drivers/pci/endpoint/functions/pci-epf-test.c

   828	
 > 829	int pci_epf_test_link_up(struct pci_epf *epf)
   830	{
   831		struct pci_epf_test *epf_test = epf_get_drvdata(epf);
   832	
   833		queue_delayed_work(kpcitest_workqueue, &epf_test->cmd_handler,
   834				   msecs_to_jiffies(1));
   835	
   836		return 0;
   837	}
   838	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (174999 bytes)