linux-kernel - Re: [PATCH V1] PCI: pciehp: Disable ACS Source Validation during hot-remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 12 Jan 2023 01:11:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vidya Sagar <vidyas@...dia.com>, bhelgaas@...gle.com
Cc:     oe-kbuild-all@...ts.linux.dev, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, vsethi@...dia.com, kthota@...dia.com,
        mmaddireddy@...dia.com, vidyas@...dia.com, sagar.tv@...il.com
Subject: Re: [PATCH V1] PCI: pciehp: Disable ACS Source Validation during
 hot-remove

Hi Vidya,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on helgaas-pci/next]
[also build test ERROR on helgaas-pci/for-linus linus/master v6.2-rc3 next-20230111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vidya-Sagar/PCI-pciehp-Disable-ACS-Source-Validation-during-hot-remove/20230111-225412
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
patch link:    https://lore.kernel.org/r/20230111145206.23919-1-vidyas%40nvidia.com
patch subject: [PATCH V1] PCI: pciehp: Disable ACS Source Validation during hot-remove
config: alpha-defconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/52cbe5f597ff5e9134cf1f8f7aba6502ab0396d2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vidya-Sagar/PCI-pciehp-Disable-ACS-Source-Validation-during-hot-remove/20230111-225412
        git checkout 52cbe5f597ff5e9134cf1f8f7aba6502ab0396d2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/pci/pci.c:18:
   include/linux/pci.h:2281:6: warning: no previous prototype for 'pci_configure_acs_sv' [-Wmissing-prototypes]
    2281 | void pci_configure_acs_sv(struct pci_dev *dev, bool flag) {}
         |      ^~~~~~~~~~~~~~~~~~~~
>> drivers/pci/pci.c:996:6: error: redefinition of 'pci_configure_acs_sv'
     996 | void pci_configure_acs_sv(struct pci_dev *dev, bool flag)
         |      ^~~~~~~~~~~~~~~~~~~~
   include/linux/pci.h:2281:6: note: previous definition of 'pci_configure_acs_sv' with type 'void(struct pci_dev *, bool)' {aka 'void(struct pci_dev *, _Bool)'}
    2281 | void pci_configure_acs_sv(struct pci_dev *dev, bool flag) {}
         |      ^~~~~~~~~~~~~~~~~~~~
--
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_93cx6.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_pci.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_reg_print.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_osm.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_proc.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here
   alpha-linux-ld: drivers/scsi/aic7xxx/aic7xxx_osm_pci.o: in function `pci_configure_acs_sv':
>> include/linux/pci.h:2281: multiple definition of `pci_configure_acs_sv'; drivers/scsi/aic7xxx/aic7xxx_core.o:include/linux/pci.h:2281: first defined here


vim +/pci_configure_acs_sv +996 drivers/pci/pci.c

   995	
 > 996	void pci_configure_acs_sv(struct pci_dev *dev, bool flag)
   997	{
   998		u16 cap;
   999		u16 ctrl;
  1000	
  1001		if (!pci_acs_enable || !dev->acs_cap)
  1002			return;
  1003	
  1004		pci_read_config_word(dev, dev->acs_cap + PCI_ACS_CAP, &cap);
  1005		pci_read_config_word(dev, dev->acs_cap + PCI_ACS_CTRL, &ctrl);
  1006	
  1007		if (flag)
  1008			ctrl |= (cap & PCI_ACS_SV);
  1009		else
  1010			ctrl &= ~(cap & PCI_ACS_SV);
  1011	
  1012		pci_write_config_word(dev, dev->acs_cap + PCI_ACS_CTRL, ctrl);
  1013	}
  1014	EXPORT_SYMBOL_GPL(pci_configure_acs_sv);
  1015	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (61554 bytes)