linux-kernel - Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1133d22-f737-ab98-6913-9ce5b0498193@csgroup.eu>
Date:   Wed, 11 Jan 2023 17:16:38 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Herve Codina <herve.codina@...tlin.com>
CC:     Li Yang <leoyang.li@....com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Qiang Zhao <qiang.zhao@....com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Shengjiu Wang <shengjiu.wang@...il.com>,
        Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <festevam@...il.com>,
        Nicolin Chen <nicoleotsuka@...il.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 02/10] soc: fsl: qe: Add support for TSA



Le 11/01/2023 à 16:06, Herve Codina a écrit :
> Hi Christophe,
> 
> On Wed, 11 Jan 2023 13:47:23 +0000
> Christophe Leroy <christophe.leroy@...roup.eu> wrote:
> 
>> Le 06/01/2023 à 17:37, Herve Codina a écrit :
>>> The TSA (Time Slot Assigner) is available in some
>>> PowerQUICC SoC such as the MPC885 or MPC866.
>>>
>>> Its purpose is to route some TDM time-slots to other
>>> internal serial controllers.
>>
>> Is the subject correct ? As far as I understand this patch adds support
>> for the TSA on the CPM (exactly on CPM1), not on the QE.
> 
> Yes exactly, it is a CPM1 support (kind of previous version of QE).
> 
> Do you think that fixing the subject is enough or do I need also
> to create a new directory drivers/soc/fsl/cpm/ and move these drivers
> (TSA and QMC) in this new directory.

I think fixing the subject should be good enough.

Today we already have in that drivers/soc/fsl/qe/ directory some code 
which is common between CPM and QE, mainly in qe_common.c

Not sure qe_common.c is the best name ever, but it has been given that 
name in commit 1291e49e8937 ("QE/CPM: move muram management functions to 
qe_common")

So let's things as they are, just be precise in the subject, and if the 
final intention is to have some TSA common to CPM and QE, let's just 
call it tsa.c . If it's dedicated to CPM at the end, then maybe call it 
cpm-tsa.c.

Maybe one day we should rename drivers/soc/fsl/qe/ to 
drivers/soc/fsl/cpm-qe/

> 
> The alternative could be to leave this driver in drivers/soc/qe/ and
> rename it to cpm-tsa.c.
> 
> For information, we have some plan to have this driver working
> with QE (not done yet).
> 
>>
>> By the way, there are already some embryo for handling TSA on QE in
>> drivers/soc/fsl/qe/qe-tdm.c
> 
> Yes but this can be seen as an extension only used by
> drivers/net/wan/fsl_ucc_hdlc.c and it supports QE only.
> 
> Not sure that qe-tdm.c will fit well if several other
> drivers instances use it.

Fair enough.

> 
>>
>>>
>>> Signed-off-by: Herve Codina <herve.codina@...tlin.com>
>>
>> Christophe
> 
> Thanks for the review,
> Hervé
>