linux-kernel - arch/arm64/kernel/proton-pack.c:953 this_cpu_set_vectors() warn: unsigned 'slot' is never less than zero.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 12 Jan 2023 01:41:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     James Morse <james.morse@....com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Catalin Marinas <catalin.marinas@....com>
Subject: arch/arm64/kernel/proton-pack.c:953 this_cpu_set_vectors() warn:
 unsigned 'slot' is never less than zero.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   7dd4b804e08041ff56c88bdd8da742d14b17ed25
commit: 558c303c9734af5a813739cd284879227f7297d2 arm64: Mitigate spectre style branch history side channels
date:   11 months ago
config: arm64-randconfig-m031-20230108
compiler: aarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
arch/arm64/kernel/proton-pack.c:953 this_cpu_set_vectors() warn: unsigned 'slot' is never less than zero.

vim +/slot +953 arch/arm64/kernel/proton-pack.c

   948	
   949	static void this_cpu_set_vectors(enum arm64_bp_harden_el1_vectors slot)
   950	{
   951		const char *v = arm64_get_bp_hardening_vector(slot);
   952	
 > 953		if (slot < 0)
   954			return;
   955	
   956		__this_cpu_write(this_cpu_vector, v);
   957	
   958		/*
   959		 * When KPTI is in use, the vectors are switched when exiting to
   960		 * user-space.
   961		 */
   962		if (arm64_kernel_unmapped_at_el0())
   963			return;
   964	
   965		write_sysreg(v, vbar_el1);
   966		isb();
   967	}
   968	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests

View attachment "config" of type "text/plain" (186046 bytes)