linux-kernel - Re: [PATCH 1/4] f2fs: reset iostat_count in f2fs_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y78LNobSXGF5N3tn@google.com>
Date:   Wed, 11 Jan 2023 11:17:10 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     Yangtao Li <frank.li@...o.com>,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] f2fs: reset iostat_count in f2fs_reset_iostat()

On 01/11, Chao Yu wrote:
> On 2023/1/5 3:20, Jaegeuk Kim wrote:
> > Hi Yangtao,
> > 
> > These are all in dev-test branch, which means you don't need to stack up more
> > patches on top of it. I just integrated most of them into two original patches.
> > Could you please take a look at this?
> > 
> > c1706cc0cd72 f2fs: add iostat support for flush
> > acd6f525e01c f2fs: support accounting iostat count and avg_bytes
> 
> +#define IOSTAT_INFO_SHOW(name, type)					\
> +	seq_printf(seq, "%-23s %-16llu %-16llu %-16llu\n",	\
> +			name":", sbi->iostat_bytes[type],			\
> +			sbi->iostat_count[type],					\
> +			iostat_get_avg_bytes(sbi, type))			\
> 
> '\' doesn't align in column, otherwise it looks good to me.

Applied with the fix.

> 
> Reviewed-by: Chao Yu <chao@...nel.org>
> 
> Thanks,