linux-kernel - Re: usb.c:undefined reference to `qe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f3c83a3-95f3-771b-3d45-3e632e2116da@csgroup.eu>
Date:   Wed, 11 Jan 2023 19:42:43 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        kernel test robot <lkp@...el.com>,
        Masahiro Yamada <masahiroy@...nel.org>
CC:     Nicolas Schier <nicolas@...sle.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Li Yang <leoyang.li@....com>,
        "oe-kbuild-all@...ts.linux.dev" <oe-kbuild-all@...ts.linux.dev>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        Qiang Zhao <qiang.zhao@....com>
Subject: Re: usb.c:undefined reference to `qe_immr'



Le 11/01/2023 à 17:01, Randy Dunlap a écrit :
> 
> 
> On 1/10/23 23:39, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@...radead.org> writes:
>>> [adding Cc's]
>>>
>>>
>>> On 1/9/23 23:59, kernel test robot wrote:
>>>> Hi Masahiro,
>>>>
>>>> FYI, the error/warning still remains.
>>>>
>>>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>>>> head:   5a41237ad1d4b62008f93163af1d9b1da90729d8
>>>> commit: 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS
>>>> date:   8 months ago
>>>> config: powerpc-randconfig-r026-20230110
>>>> compiler: powerpc-linux-gcc (GCC) 12.1.0
>>>> reproduce (this is a W=1 build):
>>>>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>          chmod +x ~/bin/make.cross
>>>>          # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7b4537199a4a8480b8c3ba37a2d44765ce76cd9b
>>>>          git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>>>>          git fetch --no-tags linus master
>>>>          git checkout 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b
>>>>          # save the config file
>>>>          mkdir build_dir && cp config build_dir/.config
>>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc olddefconfig
>>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash
>>>>
>>>> If you fix the issue, kindly add following tag where applicable
>>>> | Reported-by: kernel test robot <lkp@...el.com>
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>     powerpc-linux-ld: powerpc-linux-ld: DWARF error: could not find abbrev number 74
>>>>     drivers/soc/fsl/qe/usb.o: in function `qe_usb_clock_set':
>>>>>> usb.c:(.text+0x1e): undefined reference to `qe_immr'
>>>>>> powerpc-linux-ld: usb.c:(.text+0x2a): undefined reference to `qe_immr'
>>>>>> powerpc-linux-ld: usb.c:(.text+0xbc): undefined reference to `qe_setbrg'
>>>>>> powerpc-linux-ld: usb.c:(.text+0xca): undefined reference to `cmxgcr_lock'
>>>>     powerpc-linux-ld: usb.c:(.text+0xce): undefined reference to `cmxgcr_lock'
>>>>
>>>
>>> .config extract:
>>>
>>> #
>>> # NXP/Freescale QorIQ SoC drivers
>>> #
>>> # CONFIG_QUICC_ENGINE is not set
>>> CONFIG_QE_USB=y
>>>
>>>
>>> This is caused by (drivers/soc/fsl/qe/Kconfig):
>>>
>>> config QE_USB
>>> 	bool
>>> 	default y if USB_FSL_QE
>>> 	help
>>> 	  QE USB Controller support
>>>
>>> which does not depend on QUICC_ENGINE, where the latter build provides
>>> the missing symbols.
>>
>> So QE_USB should depend on QUICC_ENGINE no?
> 
> Yes, that would make sense, but I don't know enough about the
> hardware. I.e., could CONFIG_PPC_EP88XC have QE_USB without having
> a full QUICC_ENGINE?
> 

Kconfig says:

config PPC_EP88XC
	bool "Embedded Planet EP88xC (a.k.a. CWH-PPC-885XN-VE)"
	select CPM1
	help
	  This enables support for the Embedded Planet EP88xC board.

	  This board is also resold by Freescale as the QUICCStart
	  MPC885 Evaluation System and/or the CWH-PPC-885XN-VE.


MPC885 has an USB controller, but I was not aware Linux had any USB 
driver for the 885. Need to dig into history. Was initialy added by 
commit 3948f0e0c999 ("usb: add Freescale QE/CPM USB peripheral 
controller driver"), it explicitely says it should work on CPM.

Christophe