linux-kernel - Re: [PATCH v2] docs: kernel-hacking: discourage from calling disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y1q8wuyt.fsf@meer.lwn.net>
Date:   Wed, 11 Jan 2023 15:46:18 -0700
From:   Jonathan Corbet <corbet@....net>
To:     "A. Sverdlin" <alexander.sverdlin@...mens.com>,
        linux-doc@...r.kernel.org
Cc:     Alexander Sverdlin <alexander.sverdlin@...mens.com>,
        Federico Vaga <federico.vaga@...a.pv.it>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Manfred Spraul <manfred@...orfullife.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: kernel-hacking: discourage from calling
 disable_irq() in atomic

"A. Sverdlin" <alexander.sverdlin@...mens.com> writes:

> From: Alexander Sverdlin <alexander.sverdlin@...mens.com>
>
> Correct the example in documentation so that disable_irq() is not being
> called in atomic context.
>
> disable_irq() calls sleeping synchronize_irq(), it's not allowed to call
> them in atomic context.
>
> Link: https://lore.kernel.org/lkml/87k02wbs2n.ffs@tglx/
> Reviewed-by: Manfred Spraul <manfred@...orfullife.com>
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> ---
> Changelog:
> v2: Dropped changes to manage.c because of already applied
> https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/kernel-irq-managec-disable_irq-might-sleep.patch
>
>  Documentation/kernel-hacking/locking.rst                    | 4 ++--
>  Documentation/translations/it_IT/kernel-hacking/locking.rst | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

jon