linux-kernel - Re: [PATCH v3 07/14] blk-mq: make blk_mq_commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230111054520.GA17158@lst.de>
Date:   Wed, 11 Jan 2023 06:45:20 +0100
From:   Christoph Hellwig <hch@....de>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     hch@....de, axboe@...nel.dk, dwagner@...e.de, hare@...e.de,
        ming.lei@...hat.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, john.garry@...wei.com, jack@...e.cz
Subject: Re: [PATCH v3 07/14] blk-mq: make blk_mq_commit_rqs a general
 function for all commits

On Wed, Jan 11, 2023 at 09:01:52PM +0800, Kemeng Shi wrote:
> 1. rename orignal blk_mq_commit_rqs to blk_mq_plug_commit_rqs as
> trace_block_unplug is only needed when we dispatch request from plug list.

Why?  I think always having the trace even for the commit case seems
very useful for making the traces useful.

> +/* blk_mq_commit_rqs and blk_mq_plug_commit_rqs notify driver using
> + * bd->last that there is no more requests. (See comment in struct

This is not the normal kernel comment style.

> +static void blk_mq_commit_rqs(struct blk_mq_hw_ctx *hctx, int queued)
> +{
> +	if (hctx->queue->mq_ops->commit_rqs && queued) {
> +		hctx->queue->mq_ops->commit_rqs(hctx);
> +	}

No need for the braces.