linux-kernel - Re: [PATCH v2 05/13] serial: Convert uart_{,port_}startup() init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d3470db-b0c9-017a-fac3-c23239da3413@kernel.org>
Date:   Wed, 11 Jan 2023 06:53:33 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        Samuel Iglesias Gonsálvez <siglesias@...lia.com>,
        Rodolfo Giometti <giometti@...eenne.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 05/13] serial: Convert uart_{,port_}startup() init_hw
 param to bool

On 10. 01. 23, 13:02, Ilpo Järvinen wrote:
> Convert init_hw parameter in uart_startup() and uart_port_startup() to
> bool as code treats them like bool.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> ---
>   drivers/tty/serial/serial_core.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index c881fefa3d97..f7074ac02801 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -182,7 +182,7 @@ static void uart_port_dtr_rts(struct uart_port *uport, int raise)
>    * will be serialised by the per-port mutex.
>    */
>   static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
> -		int init_hw)
> +			     bool init_hw)
>   {
>   	struct uart_port *uport = uart_port_check(state);
>   	unsigned long flags;
> @@ -254,7 +254,7 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
>   }
>   
>   static int uart_startup(struct tty_struct *tty, struct uart_state *state,
> -		int init_hw)
> +			bool init_hw)
>   {
>   	struct tty_port *port = &state->port;
>   	int retval;
> @@ -997,7 +997,7 @@ static int uart_set_info(struct tty_struct *tty, struct tty_port *port,
>   			uart_change_speed(tty, state, NULL);
>   		}
>   	} else {
> -		retval = uart_startup(tty, state, 1);
> +		retval = uart_startup(tty, state, true);
>   		if (retval == 0)
>   			tty_port_set_initialized(port, true);
>   		if (retval > 0)
> @@ -1165,7 +1165,7 @@ static int uart_do_autoconfig(struct tty_struct *tty, struct uart_state *state)
>   		 */
>   		uport->ops->config_port(uport, flags);
>   
> -		ret = uart_startup(tty, state, 1);
> +		ret = uart_startup(tty, state, true);
>   		if (ret == 0)
>   			tty_port_set_initialized(port, true);
>   		if (ret > 0)
> @@ -1943,7 +1943,7 @@ static int uart_port_activate(struct tty_port *port, struct tty_struct *tty)
>   	/*
>   	 * Start up the serial port.
>   	 */
> -	ret = uart_startup(tty, state, 0);
> +	ret = uart_startup(tty, state, false);
>   	if (ret > 0)
>   		tty_port_set_active(port, true);
>   

-- 
js
suse labs