linux-kernel - Re: [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables to active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87dd3dc8-5ac5-1647-cd31-25f2e197e1a8@kernel.org>
Date:   Wed, 11 Jan 2023 06:59:13 +0100
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        linux-serial@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Johan Hovold <johan@...nel.org>,
        Samuel Iglesias Gonsálvez <siglesias@...lia.com>,
        Rodolfo Giometti <giometti@...eenne.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables
 to active

On 10. 01. 23, 13:02, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>

> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
...
> @@ -1881,10 +1881,10 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
>    *      Syntax:
>    *      int  MoxaPortGetLineOut(int port, int *dtrState, int *rtsState);

Hmm, this is wrong too ^^. Not sure what introduced the problem.

>    *           int port           : port number (0 - 127)
> - *           bool * dtrState    : pointer to bool to receive the current DTR
> + *           bool * dtr_active  : pointer to bool to receive the current DTR
>    *                                state. (if NULL, this function will not
>    *                                write to this address)
> - *           bool * rtsState    : pointer to bool to receive the current RTS
> + *           bool * rts_active  : pointer to bool to receive the current RTS
>    *                                state. (if NULL, this function will not
>    *                                write to this address)
>    *


-- 
js
suse labs