linux-kernel - Re: [PATCH] debugfs: allow to use regmap for print regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1859fb7306f.116a8646a961741.7679135125847887822@linux.beauty>
Date:   Wed, 11 Jan 2023 15:24:20 +0800
From:   Li Chen <me@...ux.beauty>
To:     "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     "rafael j. wysocki" <rafael@...nel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] debugfs: allow to use regmap for print regs

Hi Greg,

 > >  void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
 > > -              int nregs, void __iomem *base, char *prefix)
 > > +              int nregs, void __iomem *base, struct regmap *regmap,
 > > +              char *prefix)
 > 
 > This is confusing, please just provide a new function for regmap instead
 > of trying to overload this function.  You can use the same function
 > inside the debugfs core like this, but never export such a complex set
 > of parameters to actual users, that's just painful.

Thanks for your review, updated in v2.

Regards,
Li