linux-kernel - Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230111010744.tyzjo7noocm6owko@revolver>
Date:   Wed, 11 Jan 2023 01:07:47 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     SeongJae Park <sj@...nel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>
Subject: Re: [PATCH] maple_tree: Fix handle of invalidated state in
 mas_wr_store_setup()

* Andrew Morton <akpm@...ux-foundation.org> [230110 18:18]:
> On Tue, 10 Jan 2023 14:21:15 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> 
> > * SeongJae Park <sj@...nel.org> [230109 18:43]:
> > > Hi Andrew,
> > > 
> > > On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:
> > > 
> > > > On Mon,  9 Jan 2023 19:22:48 +0000 SeongJae Park <sj@...nel.org> wrote:
> > > > 
> > > > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett <liam.howlett@...cle.com> wrote:
> > > > > 
> > > > > > If an invalidated maple state is encountered during write, reset the
> > > > > > maple state to MAS_START.  This will result in a re-walk of the tree to
> > > > > > the correct location for the write.
> > > > 
> > > > Can we think of a Fixes: for this?
> > 
> > It wasn't really an issue until I wrote the vma iterator store
> > function.
> > 
> > You can put this before (mm-unstable git id..)
> > 9df3d25a97ec ("mm: expand vma iterator interface")
> 
> I have dropped "mm: expand vma iterator interface"'s series.  Should we
> retain this patch as a standalone thing and is the changelog still
> appropriate?

No, just drop it and I'll re-spin v3 to include maple tree fixes on the
top.