linux-kernel - Re: [PATCH 3/5] driver core: make struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y76GmvOD9KxSuD7o@kroah.com>
Date:   Wed, 11 Jan 2023 10:51:22 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Len Brown <lenb@...nel.org>,
        Stefan Richter <stefanr@...6.in-berlin.de>,
        Wolfram Sang <wsa@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>,
        Maximilian Luz <luzmaximilian@...il.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Vinod Koul <vkoul@...nel.org>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Sanyog Kale <sanyog.r.kale@...el.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Ming Lei <ming.lei@...hat.com>,
        Jilin Yuan <yuanjilin@...rlc.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ira Weiny <ira.weiny@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Won Chung <wonchung@...gle.com>, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-acpi@...r.kernel.org,
        linux-block@...r.kernel.org, linux-i2c@...r.kernel.org,
        linux-i3c@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-media@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-usb@...r.kernel.org, linux1394-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a
 const *

On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote:
> On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > The uevent() callback in struct device_type should not be modifying the
> > device that is passed into it, so mark it as a const * and propagate the
> > function signature changes out into all relevant subsystems that use
> > this callback.
> >
> > Cc: Jens Axboe <axboe@...nel.dk>
> > Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> > Cc: Len Brown <lenb@...nel.org>
> > Cc: Stefan Richter <stefanr@...6.in-berlin.de>
> > Cc: Wolfram Sang <wsa@...nel.org>
> > Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > Cc: Sean Young <sean@...s.org>
> > Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Frank Rowand <frowand.list@...il.com>
> > Cc: Maximilian Luz <luzmaximilian@...il.com>
> > Cc: Hans de Goede <hdegoede@...hat.com>
> > Cc: Mark Gross <markgross@...nel.org>
> > Cc: Vinod Koul <vkoul@...nel.org>
> > Cc: Bard Liao <yung-chuan.liao@...ux.intel.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
> > Cc: Sanyog Kale <sanyog.r.kale@...el.com>
> > Cc: Andreas Noever <andreas.noever@...il.com>
> > Cc: Michael Jamet <michael.jamet@...el.com>
> > Cc: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Cc: Yehezkel Bernat <YehezkelShB@...il.com>
> > Cc: Jiri Slaby <jirislaby@...nel.org>
> > Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > Cc: "Martin K. Petersen" <martin.petersen@...cle.com>
> > Cc: Chaitanya Kulkarni <kch@...dia.com>
> > Cc: Ming Lei <ming.lei@...hat.com>
> > Cc: Jilin Yuan <yuanjilin@...rlc.com>
> > Cc: Alan Stern <stern@...land.harvard.edu>
> > Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Cc: Sakari Ailus <sakari.ailus@...ux.intel.com>
> > Cc: Jason Gunthorpe <jgg@...pe.ca>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ira Weiny <ira.weiny@...el.com>
> > Cc: Dan Williams <dan.j.williams@...el.com>
> > Cc: Won Chung <wonchung@...gle.com>
> > Cc: alsa-devel@...a-project.org
> > Cc: devicetree@...r.kernel.org
> > Cc: linux-acpi@...r.kernel.org
> > Cc: linux-block@...r.kernel.org
> > Cc: linux-i2c@...r.kernel.org
> > Cc: linux-i3c@...ts.infradead.org
> > Cc: linux-input@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > Cc: linux-media@...r.kernel.org
> > Cc: linux-serial@...r.kernel.org
> > Cc: linux-usb@...r.kernel.org
> > Cc: linux1394-devel@...ts.sourceforge.net
> > Cc: platform-driver-x86@...r.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> (which my ACPI maintainer hat on).

thanks for the review, I'll add it to the v2 patch.

greg k-h